[5.8] Fix session resolver in RoutingServiceProvider#28438
Merged
Conversation
Member
|
Can you explain your use case a bit more? In what situation do you need to disable the |
Member
|
Hmm, I think I see what you mean. In this case the session component is hard wired with the routing while there's a check performed in |
driesvints
approved these changes
May 7, 2019
Contributor
Author
Yes, you're right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on validation exception FormRequest tries to resolve previous url from session. But if we don't use SessionServiceProvider then application fails with exception
Class session does not exist.The problem in sessionResolver that always tries to resolve session in application.