Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add html as a new valid extension for views. #28541

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
9 participants
@mathieutu
Copy link
Contributor

commented May 15, 2019

Hi,
As css is a valid extensions for views, I've added html, which allow to directly use html files as view (useful for SPAs), without renaming to *.php, *.blade.php or *.css (actually this works but.. a bit weird to have a compiled html file with a css extension 馃槄)

Moreover, it avoids to set an plain html file as a "to compile" blade view.

Tests are updated.

Thanks.
Matt'

@taylorotwell taylorotwell merged commit b1119eb into laravel:5.8 May 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amirex128

This comment has been minimized.

Copy link

commented May 22, 2019

Wooow
Thanks mathieutu.
It's a best idea for SPA

@phpduck

This comment has been minimized.

Copy link

commented May 22, 2019

@AminulBD what do you mean for SPA?

@RichardStyles

This comment has been minimized.

Copy link

commented May 22, 2019

@AminulBD what do you mean for SPA?

This is likely for something like Inertia.js or similar where you need to have a chunk of HTML which you inject into the page for a SPA.

Very handy.

@MattWohler

This comment has been minimized.

Copy link

commented May 22, 2019

@phpduck SPA's don't require that your markup be presented in PHP, JS, etc.

@amirex128

This comment has been minimized.

Copy link

commented May 23, 2019

very good

@Mombuyish

This comment has been minimized.

Copy link

commented May 24, 2019

Awesome, that's very helpful

@sensoeurn

This comment has been minimized.

Copy link

commented May 24, 2019

Nice 馃グ

@AminulBD

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

@AminulBD what do you mean for SPA?

@phpduck I'm confused, Mistakenly you mentioned me here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.