[5.8] Add html as a new valid extension for views.#28541
Merged
Conversation
|
Wooow |
|
@AminulBD what do you mean for SPA? |
This is likely for something like Inertia.js or similar where you need to have a chunk of HTML which you inject into the page for a SPA. Very handy. |
|
@phpduck SPA's don't require that your markup be presented in PHP, JS, etc. |
|
very good |
|
Awesome, that's very helpful |
|
Nice 🥰 |
Contributor
@phpduck I'm confused, Mistakenly you mentioned me here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As css is a valid extensions for views, I've added html, which allow to directly use html files as view (useful for SPAs), without renaming to *.php, *.blade.php or *.css (actually this works but.. a bit weird to have a compiled html file with a css extension 😅)
Moreover, it avoids to set an plain html file as a "to compile" blade view.
Tests are updated.
Thanks.
Matt'