Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add html as a new valid extension for views. #28541

Merged
merged 1 commit into from
May 15, 2019

Conversation

mathieutu
Copy link
Contributor

Hi,
As css is a valid extensions for views, I've added html, which allow to directly use html files as view (useful for SPAs), without renaming to *.php, *.blade.php or *.css (actually this works but.. a bit weird to have a compiled html file with a css extension 😅)

Moreover, it avoids to set an plain html file as a "to compile" blade view.

Tests are updated.

Thanks.
Matt'

@taylorotwell taylorotwell merged commit b1119eb into laravel:5.8 May 15, 2019
@amirex128
Copy link

Wooow
Thanks mathieutu.
It's a best idea for SPA

@ghost
Copy link

ghost commented May 22, 2019

@AminulBD what do you mean for SPA?

@RichardStyles
Copy link

@AminulBD what do you mean for SPA?

This is likely for something like Inertia.js or similar where you need to have a chunk of HTML which you inject into the page for a SPA.

Very handy.

@MattWohler
Copy link

@phpduck SPA's don't require that your markup be presented in PHP, JS, etc.

@amirex128
Copy link

very good

@Mombuyish
Copy link

Awesome, that's very helpful

@sensoeurn
Copy link

Nice 🥰

@AminulBD
Copy link
Contributor

@AminulBD what do you mean for SPA?

@phpduck I'm confused, Mistakenly you mentioned me here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants