Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Check presence of force flag in command signature #28742

Merged
merged 1 commit into from
Jun 6, 2019
Merged

[5.8] Check presence of force flag in command signature #28742

merged 1 commit into from
Jun 6, 2019

Conversation

nie7321
Copy link
Contributor

@nie7321 nie7321 commented Jun 5, 2019

When using the ConfirmableTrait, you get an exception in production if you don't have force in the command signature:

Symfony\Component\Console\Exception\InvalidArgumentException: The "force" option does not exist.

This was a non-obvious error, and caught me by surprise during a deployment -- you'd only get it when your app was in production mode.

This PR makes force an optional feature when using ConfirmableTrait.

@taylorotwell taylorotwell merged commit 5714b21 into laravel:5.8 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants