[6.x] Use value helper where possible #29959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpok
force-pushed
the
feature/use-value-helper
branch
from
afab240
to
f22b5fa
Compare
taylorotwell
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Remove Container dependency on Illuminate\Support For standalone projects, pulling in all of Illuminate\Support is a bit overkill, given that we're using only a couple of functions from the package. This commit opts to duplicate the two helper functions inside the container namespace (so they'll be picked up by a subtree split), which also removes reliance on any custom global functions. This goes beyond effectively reverting #29959, as the container used Arr::wrap() before adding in the value() helper. * Update Util.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framework already uses the value helper many places, this pull request updates the remaining three occurrences for consistency.
Both the Console and the Container package already depends on the Support package so this does not introduce new dependency.