Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix callback return for DurationLimiter #30143

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[6.x] Fix callback return for DurationLimiter #30143

merged 1 commit into from
Oct 1, 2019

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Sep 30, 2019 •
edited
Loading

The callback return value wasn't properly cascaded back as a result.

Fixes #28729

@driesvints
Fix callback return for DurationLimiter
b736683 
The callback return value wasn't properly cascades back as a result.

Fixes #28729
@taylorotwell taylorotwell merged commit d509298 into laravel:6.x Oct 1, 2019
@driesvints driesvints deleted the fix-duration-limiter-return branch October 1, 2019 12:40
i-bajrai pushed a commit to i-bajrai/framework that referenced this pull request Oct 4, 2019
@driesvints @i-bajrai
Fix callback return for DurationLimiter (laravel#30143)
a7e2801 
The callback return value wasn't properly cascades back as a result.

Fixes laravel#28729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[5.8] Inconsistent return values between Redis limiters
2 participants
@driesvints @taylorotwell