Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Don't add extra '?' for empty query string #30280

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

nanaya
Copy link
Contributor

@nanaya nanaya commented Oct 15, 2019

For route specified as

new Route(['GET'], 'foo/bar/{baz?}', ['as' => 'optional'])

and generated with

route('optional', ['baz' => null])

currently it'll generate url with extraneous ? at the end (/foo/bar?).

This PR changes it to generate cleaner url without useless ? at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants