[6.x] Handle ajax requests in RequirePassword middleware #30390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpok
force-pushed
the
feature/password-confirmation-ajax-error
branch
from
e6179d8
to
bcb06bc
Compare
netpok
force-pushed
the
feature/password-confirmation-ajax-error
branch
from
bcb06bc
to
93eb836
Compare
|
Can't use foundation helpers from components. Used response factory instead. |
|
Sorry, I missed that. |
Omranic
added a commit
to rinvex/cortex-auth-classic
that referenced
this pull request
Nov 9, 2019
Omranic
added a commit
to rinvex/cortex-auth-classic
that referenced
this pull request
Nov 23, 2019
* release/v4.1.0: Bump version Add dockblock note for the future Refactor Login Throttle to use "ThrottleRequests" middleware Move "Remember previous URL for later redirect back" to exception handler Laravel v6.4.x / Handle ajax requests in RequirePassword middleware (#30390, 331c354) https://blog.laravel.com/laravel-v6-4-0-released laravel/framework#30390 laravel/framework@331c354 Update Reauthenticate middleware to be compatible with Laravel v6.3 Use contracts for the RequirePassword middleware (#30215) laravel/framework@53b6471 Refactor Reauthentication feature to be compatible with the new Laravel v6.2 feature https://laravel-news.com/new-password-confirmation-in-laravel-6-2 change account display name as the two children account and settings have the same name (#87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly introduced RequirePassword middleware does not handle ajax requests very well.
This pull request addresses this problem, for easier handling via ajax frontend libraries (like axios), I'm proposing that the error should be sent with error code
423 Lockedas this would allow relatively easy handling with response interceptors.Considered alternative error codes:
I'm open for different error code ideas.