[6.x] Fix routing bug that causes missing parameters to be ignored

[GuidoHendriks]

I noticed there's a bug with creating a URL. When there's a named parameter that's not in the route, it gets added to the query string. But when there's no other parameters, the missing parameter gets ignored.

For example, I had a route similar to this:

Route::delete('/foo/{bar}/test')->name('test-route');

When using it like this:

route('test-route', ['foo' => 'bar'])

Previously this would be the result: /foo/bar/test. But since the change that the name should match, this is no longer the case. Then it should fail and throw an error because there's a missing parameter, but instead it removes the parameter token and leaves an invalid URL: /foo//test?foo=bar.

[driesvints]

Isn't this the same as #30536 ?

Also: we can't merge this on the current release branch for people who are expecting the current behavior.

[GuidoHendriks]

With this route - with a required parameter:

Route::delete('/foo/{required-parameter}/test')->name('test-route');

How can both this:

route('test-route') // error

And this:

route('test-route', ['unrelated-parameter' => 123]) // /foo//test?unrelated-parameter=123

Both be the expected behaviour? Is the intention to enforce or not to enforce required parameters?

[taylorotwell]

After reviewing with @driesvints we agree this is a bug. Thanks!

[driesvints]

Thanks @GuidoHendriks & @netpok

[GuidoHendriks]

Thanks guys. Happy to help where I can, it’s the least in can do. 👍