Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] TransactionCommitted event doesn’t contain transaction level I’d expect it to #30883

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@simoebenhida
Copy link
Contributor

simoebenhida commented Dec 19, 2019

Fire transactionCommitted event before decrementing the transaction level ! as described here #30756

@simoebenhida simoebenhida changed the title [6.x] TransactionCommitted event doesn’t contain transaction level I’d expect it to #30756 [6.x] TransactionCommitted event doesn’t contain transaction level I’d expect it to Dec 19, 2019
@taylorotwell taylorotwell merged commit 9343d72 into laravel:6.x Dec 19, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nanaya nanaya mentioned this pull request Dec 23, 2019
nanaya added a commit to nanaya/osu-web that referenced this pull request Dec 23, 2019
Our current transaction manager depends on transaction level to be decremented before the committed event is fired but the behavior is changed in 6.9.0 (laravel/framework#30883) and as a result I don't see any easy way to determine whether or not a connection has finished all of its transactions.
driesvints added a commit that referenced this pull request Dec 30, 2019
…ns level (#30883)"

This reverts commit 9343d72.
driesvints added a commit that referenced this pull request Jan 7, 2020
…ns level (#30883)"

This reverts commit 9343d72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.