Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Deprecate sendNow and remove unneeded check #30999

Merged
merged 3 commits into from Jan 2, 2020

Conversation

@themsaid
Copy link
Member

themsaid commented Jan 2, 2020

This PR removes PendingMail::sendNow since it won't actually send the mail now if the mailable implements ShouldQueue. It works same as send.

It Also removes the ShouldQueue check from PendingMail::send since the check will happen in Mailer::sendMailable anyway.

Finally, it removes the $mailable->delay check since it'll be checked in Mailable::queue anyway.

Copy link
Member

GrahamCampbell left a comment

Looks great. 👍

@taylorotwell taylorotwell merged commit 0b748bc into laravel:6.x Jan 2, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.