[7.x] Adding console command assertion expectsChoice()#32139
Merged
taylorotwell merged 3 commits intoMar 30, 2020
Conversation
Contributor
|
+1 👌 |
Contributor
Author
|
@taylorotwell any idea how we can cover the whole console assertion stuff with tests? |
imacrayon
pushed a commit
to imacrayon/framework
that referenced
this pull request
Mar 31, 2020
* adding console command assertion expectsChoice() * Update InteractsWithConsole.php * Update InteractsWithConsole.php Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new console test method for asking
choices.Current State
You can ask a multiple-choice question in a Laravel command with the
choicemethod:Currently, you can
only assertthemessageof this question and define a reply like:What you
cannot testhere are the given choices:['Taylor', 'Dayle']Depending on how your command looks like, these choices may change through input.
Solution
In order to solve this problem, this PR adds a new method to expect choices. The code above can now be tested like:
Next to the message and the reply, you can now define the expected available choices as well.
Per default we compare both arrays ignoring the order using
assertEqualsCanonicalizing, if needed can switch toassertEqualsvia a fourth parameter.