[7.x] Add support for SQL Server LoginTimeout to specify seconds to wait before failing connection attempt #33472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seconds to wait before failing connection attempt.
|
If accepted should probably also be added to https://github.com/laravel/laravel/blob/195faa16cbeabc84b0eb9c9f4227ead762c93575/config/database.php#L81-L92 so it's "discoverable" at least for new installations |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing functionality for the SqlServerConnector class doesn't allow a developer to specify the number of seconds to wait before failing a connection attempt. Without this support, a SQL Server connection attempt can take 30 seconds to fail.
Setting the connection timeout is done by adding the LoginTimeout connection option to the DSN string. Example: "sqlsrv:Server=server;Database=dbname;LoginTimeout=5"
Resources: