[7.x] Make HasTimestamps::updateTimestamps public #33953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've a use-case where I construct models but can't save them yet but
they should reflect the state of new models as good as it gets,
including the timestamps for created/updated, which I want to do from
outside the model
Similar to the `touch()` method:
```php
public function touch()
{
if (! $this->usesTimestamps()) {
return false;
}
$this->updateTimestamps();
return $this->save();
}
```
But I don't want to save the model _yet_.
I can call `usesTimestamps()` from outside the model as its
already public but not yet `updateTimestamps`, thus the PR.
|
This is a major breaking change, and will be reverted on 7.x, and moved to 8.x. |
GrahamCampbell
added a commit
that referenced
this pull request
Aug 24, 2020
This reverts commit 28f847f.
taylorotwell
pushed a commit
that referenced
this pull request
Aug 24, 2020
GrahamCampbell
added a commit
that referenced
this pull request
Aug 24, 2020
GrahamCampbell
added a commit
that referenced
this pull request
Aug 24, 2020
taylorotwell
pushed a commit
that referenced
this pull request
Aug 24, 2020
|
Uh, thanks for the update and sorry for the trouble. I tried to think about this but it didn't occur to me that relaxing the visibility might be such a problem. |
This was referenced Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've a use-case where I construct models but can't save them yet but
they should reflect the state of new models as good as it gets,
including the timestamps for created/updated, which I want to do from
outside the model
Similar to the
touch()method:But I don't want to save the model yet.
I can call
usesTimestamps()from outside the model as itsalready public but not yet
updateTimestamps, thus the PR.