[8.x] Make more Builder/Grammar methods public #34102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've a use case where I want to composite functionality which can take advantage of the existing code here, without e.g. extending the Query Builder
I've a use case where I want to composite functionality which can take advantage of the existing code here, without e.g. extending the Grammar
|
Thanks! Sorry for the wrong branch, didn't realize 8.x already existed. Go Team Laravel! |
|
Yeh, we usually cut a new branch around 2-3 weeks before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar in spirit to #33953 (which ultimately was only applied to 8.x via #33984 )
I've use cases where I want to be able to re-use Builder/Grammar without having to extend them, as they might already be extended from other packages and thus makes compositing via replacing very hard.
By having those method public, they can be easier re-used from the outside. Some rational of this is explained in an issue over at staudenmeir/laravel-upsert#21 (comment) about issues I faced using a package providing upsert, and using a different approach to implement this.
Thanks!