[8.x] Add ability to clear queues #34330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Levitsky-Offmade
approved these changes
Sep 16, 2020
|
Are you able to make a PR to laravel/horizon to ensure it works on there? |
|
sure @taylorotwell, I'll send across a PR to Horizon. Thanks! |
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the abilities to clear queues. Right now, if a user has to clear the queue, the implementation would depend on the queue driver and there's no easy way to do so with the framework. This would be very helpful in development (e.g. clear the queue right before re-seeding DB/refreshing migrations to avoid DB mismatch) and may also be helpful in production (in specific emergency cases).
It has been suggested many times in packages such as Horizon (laravel/horizon#328) and also I can see a lot of StackOverflow questions asking how to clear the queue in Laravel. I think if the framework directly supports this in the various drivers, it would be easier for packages like Horizon to extend the capability to clear queues and also very easy/convenient for Laravel users.