Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the queue option for Artisan Commands #6484

Closed
wants to merge 1 commit into from

Conversation

stefanbauer
Copy link

The queue argument was replaced by an option. It took me some time to find that in my production code. I thought it might be useful for the upgrade guide. This is my very first PR to the docs, so I hope I did everything right. If not, let me know.

@paras-malhotra
Copy link
Contributor

@stefanbauer which command are you referring to here? queue:clear was only introduced in 8.x and queue:work had a --queue option in 7.x as well.

@stefanbauer
Copy link
Author

@stefanbauer which command are you referring to here? queue:clear was only introduced in 8.x and queue:work had a --queue option in 7.x as well.

That's not true. queue:clear was already available in L7 as we make heavy use of it in there.

@paras-malhotra
Copy link
Contributor

No, it wasn't. 😅 Here's the PR for queue:clear: laravel/framework#34330

@stefanbauer
Copy link
Author

Seems Horizon adds this command on L7. So not sure if it makes sense to add in the docs here, but it still has changed in the end.

@paras-malhotra
Copy link
Contributor

For Horizon as well, this was only introduced in 5.x (Laravel 8). Here's the PR for that: laravel/horizon#892. Could be that you have your own command (not shipped with Laravel) in production

@stefanbauer
Copy link
Author

Oh, this was my fault. Totally right lol. I close it 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants