[8.x] Remove --column-statistics for MariaDB schema dump
#34442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `php artisan schema:dump` is run with a MariaDB connection, the warning message `mysqldump: unknown variable 'column-statistics=0'` appears, but the dump is otherwise successful. This is because the `--column-statistics` flag is MySQL specific, and does not exist in MariaDB's version of `mysqldump`. Let's remove the `--column-statistics` flag from the `schema:dump` command when it is run against a MariaDB connection. There should be no issues with removing the flag in MariaDB as the flag has no effect otherwise and `schema:dump` still functions correctly with MariaDB even with the flag removed.
|
@Xenonym What about |
GrahamCampbell
changed the title
--column-statistics for MariaDB schema dump--column-statistics for MariaDB schema dump
|
@iKlsR this PR (and the associated issue) was about MariaDB. Your problem seems to be with an older MySQL version. You should probably open a new issue for older MySQL server versions. |
|
Hmm. From prior closed issues seems like it's a works on my machine 🤷♂️ case so when it pops up again or someone gets around to it one day I guess. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32552.
When
php artisan schema:dumpis run with a MariaDB connection, the warning messageappears, but the dump is otherwise successful.
This is because the
--column-statisticsflag is MySQL specific, and does not exist in MariaDB's version ofmysqldump.Let's remove the
--column-statisticsflag from theschema:dumpcommand when it is run against a MariaDB connection.There should be no issues with removing the flag in MariaDB as the flag has no effect otherwise and
schema:dumpstill functions correctly with MariaDB even with the flag removed.