Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Remove --column-statistics for MariaDB schema dump #34442

Merged
merged 1 commit into from
Sep 21, 2020
Merged

[8.x] Remove --column-statistics for MariaDB schema dump #34442

merged 1 commit into from
Sep 21, 2020

Commits on Sep 21, 2020

  1. Remove --column-statistics for MariaDB schema dump

    When `php artisan schema:dump` is run with a MariaDB connection, the
    warning message `mysqldump: unknown variable 'column-statistics=0'`
    appears, but the dump is otherwise successful.
    
    This is because the `--column-statistics` flag is MySQL specific, and
    does not exist in MariaDB's version of `mysqldump`.
    
    Let's remove the `--column-statistics` flag from the `schema:dump`
    command when it is run against a MariaDB connection.
    
    There should be no issues with removing the flag in MariaDB as the flag
    has no effect otherwise and `schema:dump` still functions correctly
    with MariaDB even with the flag removed.
    Xenonym committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f4e4bca View commit details
    Browse the repository at this point in the history