Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] add Str::betweenAll() #38472

Closed
wants to merge 3 commits into from
Closed

[8.x] add Str::betweenAll() #38472

wants to merge 3 commits into from

Conversation

SjorsO
Copy link
Contributor

@SjorsO SjorsO commented Aug 20, 2021

This PR adds a Str::betweenAll() method:

$string = <<<STR
Follow your order with <a href="http://example.com/t&t">Track & Trace</a>

Or <a href="http://example.com/unsub">unsubscribe</a> forever.
STR;

Str::betweenAll($string, 'href="', '"'); // ['http://example.com/t&t', 'http://example.com/unsub']

My use-case is that I want to visit the first link from an email in a Dusk test. I intercept the email, and have to get the first link. With this new method I can do so using Str::betweenAll($email->body, 'href="', '"')[0].

This new method is similar to Str::between():

Str::between('[a]', '[', ']') // 'a'
Str::betweenAll('[a]', '[', ']') // ['a']

Str::between('[a] [b]', '[', ']') // 'a] [b'
Str::betweenAll('[a] [b]', '[', ']') // ['a', 'b']

@foremtehan
Copy link
Contributor

return Collection imo

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants