[9.x] Remove duplicate queries to find batch#41121
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Feb 21, 2022
Merged
Conversation
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everytime the
Batchable::batch()method is called, a database query is performed using theDatabaseBatchRepository.So when we are recording successful/failed jobs, first we fetch the batch to check if it's null, and then we fetch it again to record the job.
Since it's rendundant to fetch the batch two times from the database, this PR fetches the batch once, and if it exists, it will record the job.