[9.x] Query PostgresBuilder fixes for renamed config 'search_path' - #41215
Merged
taylorotwell merged 1 commit intoFeb 24, 2022
Merged
Conversation
derekmd
force-pushed
the
fix-postgres-builder-search-path
branch
from
February 24, 2022 04:10
0704627 to
557908c
Compare
derekmd
changed the title
PostgresBuilder fixes for config('database.connections.pgsql.search_path') renamePostgresBuilder fixes for renamed config 'search_path'
….search_path')`
1. `PostgresBuilder::parseSchemaAndTable()`
* Needs a fallback to <= 8.x `config('database.connections.pgsql.schema')`
when 9.x renamed `config('database.connections.pgsql.search_path')`
is missing.
* Remove duplicate `$user` variable `config('database.connections.pgsql.username')`
replacement handling already done by `parseSearchPath()`.
2. `PostgresBuilder::getAllTables()` + `getAllViews()` + `parseSchemaAndTable()`
Apply the `parseSearchPath()` fixes applied to PostgresConnector:
laravel#41088
3. `DatabasePostgresBuilderTest`
Add more test cases and use terse method names instead of extensive
comments to concisely communicate each case.
derekmd
force-pushed
the
fix-postgres-builder-search-path
branch
from
February 24, 2022 04:16
557908c to
fa8a17b
Compare
Member
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41213 and more
PostgresBuilder::parseSchemaAndTable()config('database.connections.pgsql.search_path')fallback to <= 8.x key'database.connections.pgsql.schema'.$userschema variable replacement already done byparseSearchPath()that this method calls.PostgresBuilder::getAllTables()+getAllViews()+parseSchemaAndTable()config('database.connections.pgsql.search_path')#41088 fixed valid schemas like 'test-db' not being parsed. These 3 methods still have that problem.parseSearchPath()was copy & pasted betweenPostgresConnectorandPostgresBuilderwith a one-line difference for $user replacements.ParsesSearchPathtrait to fixPostgresBuildermethods not handling all search paths.DatabasePostgresBuilderTestconfig('database.connections.pgsql.schema')and cover an array of search paths with non-alphanumeric strings containing hyphen or accented characters.