Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix deprecation warnings from route:list when filtering on name or domain #41421

Merged
merged 2 commits into from
Mar 10, 2022
Merged

[9.x] Fix deprecation warnings from route:list when filtering on name or domain #41421

merged 2 commits into from
Mar 10, 2022

Conversation

hmazter
Copy link
Contributor

@hmazter hmazter commented Mar 10, 2022

Cast route name and domain to string since they can be null when filtering with --name or --domain

Added a test to make sure the filtering was still working and does not throw any deprecation warnings.

More specific fix as mentioned in #41419

@GrahamCampbell GrahamCampbell changed the title Fix deprecation warnings from route:list when filtering on name or domain [9.x] Fix deprecation warnings from route:list when filtering on name or domain Mar 10, 2022
@taylorotwell taylorotwell merged commit f20b074 into laravel:9.x Mar 10, 2022
@hmazter hmazter deleted the route-list-deprecation-warning branch March 10, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants