[9.x] Improve command name handling#41595
Merged
taylorotwell merged 2 commits into9.xfrom Mar 21, 2022
Merged
Conversation
driesvints
force-pushed
the
refactor-commands
branch
from
7568bfb to
ed2b937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how the default name and description of a command are returned by giving precedence to the command signature and name property, just like in a command's constructor. This allows Symfony's lazy loading of a command to continue to function, without having to resolve the command from the container. Additionally, this PR allows you to make the new command attribute optional with Symfony 6.1
The most important changes in this PR are the overwriting of the
getDefaultNameandgetDefaultDescriptionmethods.In Laravel v10, we may safely remove the deprecated static
$defaultNameproperty.