[9.x] Fix ExcludeIf constructor#41931
Merged
Merged
Conversation
BrandonSurowiec
added a commit
to BrandonSurowiec/framework
that referenced
this pull request
Jun 27, 2022
This applies the same fixes to ProhibitIf as ExcludeIf. - Missing @throws declaration in docblock: laravel#41729 - Enforces a boolean in the constructor: laravel#41931 laravel#41969 Also fixes the ExcludeIf @var docblock to match as a \Closure
taylorotwell
pushed a commit
that referenced
this pull request
Jun 27, 2022
taylorotwell
pushed a commit
to illuminate/validation
that referenced
this pull request
Jun 27, 2022
This applies the same fixes to ProhibitIf as ExcludeIf. - Missing @throws declaration in docblock: laravel/framework#41729 - Enforces a boolean in the constructor: laravel/framework#41931 laravel/framework#41969 Also fixes the ExcludeIf @var docblock to match as a \Closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ExcludeIfconstructor only accepts a callable or bool value. But the current check could not ensure that, it accepts either numbers, string, object or anything else. I've just fixed and added missing tests.