Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Trim zwnbsp #41949

Merged
merged 2 commits into from
Apr 13, 2022
Merged

[9.x] Trim zwnbsp #41949

merged 2 commits into from
Apr 13, 2022

Conversation

allowing
Copy link
Contributor

@allowing allowing commented Apr 13, 2022 •
edited
Loading

"ZWNBSP" mean "Zero Width No-Break SPace"

The '\s' does not include it

image

This was referenced Apr 13, 2022
Merged
Closed
@taylorotwell taylorotwell merged commit 8a10e3f into laravel:9.x Apr 13, 2022
@GrahamCampbell GrahamCampbell changed the title trim zwnbsp [9.x] Trim zwnbsp Apr 13, 2022
@allowing allowing deleted the trim_zwnbsp branch April 14, 2022 05:44
@allowing allowing mentioned this pull request Apr 14, 2022
Merged
@rodrigopedra
Copy link
Contributor

Hi @allowing would you send the same change to the recently added Str::squish()?

I basically ported the same fix I used here before on PR #41877

I guess it would be nice to keep both places consistent. Unfortunately this week I won't have time to work on this.

@allowing
Copy link
Contributor Author

@rodrigopedra :)
I may forget to reply to you, which has been implemented here. Supplement the reply for the convenience of other netizens. #41971

@restuff restuff mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allowing @rodrigopedra @taylorotwell @rfvjyy