Repository navigation
[9.x] Factory fails to eval models and factories when returned from closure - #42344
Merged
taylorotwell merged 2 commits intoMay 11, 2022
Merged
taylorotwell merged 2 commits into
taylorotwell merged 2 commits into
Conversation
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
…losure (laravel#42344) * Add test to check a factory closure attribute returning a factory is resolved * Fix evaluation of factories and models when returned from a closure in factory definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v9.12.0, due to the changes made in #42241, model factories now fail to evaluate both models and factories when they are returned from a closure.
This is due to models and factories now being resolved first and closures second.
To fix this issue, while maintaining the functionality added in #42241, the resolution of models and factories would need to be repeated again after resolving closures.
A rudimentary example:
In the latest release, the code above would throw an exception - occurring when the database driver attempts to bind a factory object the query statement (see failing test).