Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Allow underline in numeric validation values #42578

Closed

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented May 30, 2022

PHP 7.4 allows putting the underline character in integers for more readability, like:
"1_500_000" instead of: "1500000"
This PR allows putting underline in numbers of validation rules: Numeric|Between:500_000,1_000_000

  • It also adds some important missing tests.

@imanghafoori1 imanghafoori1 changed the title allow underline in numeric validation values [9.x] Allow underline in numeric validation values May 30, 2022
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants