[9.x] TransactionCommitting#44608
Conversation
|
Naming can be improved to align with other similar events |
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions! If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response. |
|
@taylorotwell Hello. The event must be done on the side of the framework. A standalone package would be difficult to maintain and keep ManagesTransactions up to date. Any change to the framework will break the package. I believe adding an event won't harm your product. For example, this event can be used in logging, in profiling tools, etc. For example, event sourcing model. Inside the transaction, we will fill some of our state and, before the last commit, write logs with one big insert request, inside the same transaction. These are all examples, but they are very important, I think. |
|
@taylorotwell I will describe in detail my case of using this functionality. I am developing a package for working with virtual wallets. Now I have a custom service for working with transactions in the database. When developers call |
Hello.
There was a need for a committing event, it would be great to add to the framework.
Thanks.