Repository navigation
[9.x] Add zero-width space to trimmed characters in TrimStrings middleware - #44906
Merged
Merged
Conversation
Contributor
Author
|
Also, I can try and add a test for this if necessary. |
Member
|
Yeah we would definitely want a test for this I think. |
taylorotwell
marked this pull request as draft
November 11, 2022 14:46
Member
|
Please mark as ready for review when it has a test. |
Contributor
Author
|
I tried to think of multiple situations with the tests, I hope it's fine like this! |
tomcodes
marked this pull request as ready for review
November 11, 2022 15:37
Contributor
Author
|
woops, I have noticed a tiny typo issue in the last test, should I open a new pull request? The title should not be The test is still valid, it's just the title that does not fit the test name. |
Member
|
@tomcodes yes feel free to send in a new pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a weird bug recently when adding a job to the queue when the content had a zero-width space present somewhere.
The bug I had was:
Unable to JSON encode payload. Error code: 5It took me a while to corner this issue to a zero-width space present in a user firstname.
I was wondering also if would be interesting to add a middleware to actually remove those characters also from within the fields instead of just the side. I am willing to create another pull request if that need can benefit more people.
Github does not show the diff, so here is a visual diff:
Before

After
