Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Allow use of brick/math 0.9.3 to enable compatibility with Nova 3 #45774

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

colincameron
Copy link
Contributor

@colincameron colincameron commented Jan 23, 2023

9.48 broke compatibility with Nova 3.32 due to the introduction of brick/math in #45602 - trying to update to 9.48 gives the following problem:

Problem 1
- laravel/framework v9.48.0 requires brick/math ^0.10.2 -> satisfiable by brick/math[0.10.2].
- Conclusion: don't install brick/math 0.10.2 (conflict analysis result)
- Root composer.json requires laravel/nova * -> satisfiable by laravel/nova[3.32.0].
- Root composer.json requires laravel/framework ^9.48 -> satisfiable by laravel/framework[v9.48.0, 9.x-dev].
- laravel/nova 3.32.0 requires brick/money ^0.5.0 -> satisfiable by brick/money[0.5.0, 0.5.1, 0.5.2, 0.5.3].
- brick/money[0.5.0, ..., 0.5.3] require brick/math ~0.7.3 || ~0.8.0 || ~0.9.0 -> satisfiable by brick/math[0.7.3, ..., 0.9.3].
- You can only install one version of a package, so only one of these can be installed: brick/math[0.7.3, ..., v0.11.x-dev].
- laravel/framework 9.x-dev requires brick/math ^0.10.2|^0.11 -> satisfiable by brick/math[0.10.2, 0.11.0, v0.11.x-dev].
- Conclusion: don't install brick/math 0.11.0 (conflict analysis result)

The requirement for brick/math was extended to allow 0.11 in #45762. This PR relaxes the requirement further to allow 0.9.3.

None of the changes from 0.9.3 to 0.10.2 in brick/math affect its use in Laravel. The changes between versions of brick/math are minimal.

@taylorotwell taylorotwell merged commit 247735e into laravel:9.x Jan 23, 2023
@colincameron colincameron deleted the fix-math-dependency branch January 23, 2023 18:01
@GrahamCampbell GrahamCampbell changed the title Allow use of brick/math 0.9.3 to enable compatibility with Nova 3 [9.x] Allow use of brick/math 0.9.3 to enable compatibility with Nova 3 Jan 24, 2023
@jonnott
Copy link
Contributor

jonnott commented Feb 1, 2023

NB: @colincameron this change is also a win for users of https://github.com/pascaldevink/shortuuid for the same reason (brick/math dependency) 👍

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants