[9.x] Send along value to InvalidPayloadException#47223
Merged
Conversation
driesvints
changed the title
driesvints
marked this pull request as ready for review
May 26, 2023 06:38
driesvints
marked this pull request as draft
May 26, 2023 06:38
jbrooksuk
approved these changes
May 26, 2023
jbrooksuk
left a comment
jbrooksuk
left a comment
Member
There was a problem hiding this comment.
My only concern is that the value could be quite large. I wonder if we should truncate in some way?
Member
Author
|
@jbrooksuk this is only useful if we can inspect the full value. Otherwise this has no meaning. We'd want to retry encoding and inspect the value to see why it fails. This value is only kept in memory afaik. |
driesvints
marked this pull request as ready for review
May 29, 2023 12:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will send along the value that's being attempted to encode with the
InvalidPayloadExceptionthat's thrown if there's an error. This hopefully gives more insight when debugging why the payload is invalid.