Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] avoid duplicates in fillable/guarded on merge #47351

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

onlime
Copy link
Contributor

@onlime onlime commented Jun 5, 2023

A model's $fillable or $guarded array should not contain duplicates if we try to merge attributes that are already present.

This is a follow-up for #47264 which was merged and published in Laravel v10.13.0

@ondrejmirtes
Copy link
Contributor

The failure is PHPStan's fault which I'm fixing in #47352

@taylorotwell taylorotwell merged commit 6ba1b83 into laravel:10.x Jun 5, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants