[10.x] Dispatch model pruning started and ended events #47669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morloderex
reviewed
Jul 6, 2023
| @@ -49,10 +51,14 @@ public function handle(Dispatcher $events) | |||
| } | |||
|
|
|||
| if ($this->option('pretend')) { | |||
| $events->dispatch(new ModelsPruningStarted($models->toArray())); | |||
There was a problem hiding this comment.
@ziadoz Would it be an idea to pass the pretending flag from the command into the starting and ending events respectively?
There was a problem hiding this comment.
@morloderex Yes, I think it would be a good idea, but adding it here would be inconsistent with the existing migration events. It might be worth implementing in a separate PR though.
|
Renamed - also don't think they should run on pretend tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the model pruning command has completed I want to run some additional SQL, such as
ANALYZE TABLE, on the affected models' tables. The existing events the command dispatches aren't sufficient to do this because they fire per chunk of records deleted. This PR adds starting and ending events, similar to the migrate command, which include an array of the model classes that were pruned.