[10.x] Add option to adjust database default lock timeout #47854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelharkes
changed the title
|
see the discussion #47852 i started to further understand the whole locking setup. |
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use jobs to make unique notifications, delaying the job till end of the week to provide a weekly notification based on a certain event happening in the system.
Currently we are using database locks and noticed default the lock date is 1 day.
This PR makes this configurable, as most other cache lock systems there is no default timeout on the locks, i thought making it configurable, for us putting it to 1 week or 1 year would suffice.
Origin of 1 day expire
seems to have been there since the start of database locking: b78880a
hypotheses: Probably an afterthought that has never been cleaned up properly.