Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Using complete insert for mysqldump when appending migration dump to schema file #48126

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

emulgeator
Copy link
Contributor

@emulgeator emulgeator commented Aug 21, 2023

Because of a flickering issue in mysql dump what causes sometimes that the columns in an insert command were in a wrong order. Fixing this issue can be done easily by adding the column names to the generated insert query.

See example

INSERT INTO `migrations` VALUES (1,1, '2023_08_09_120725_init_schema');

Which becomes the following after this change:

INSERT INTO `migrations` (`id`, `migration`, `batch`) VALUES (1,'2023_08_09_120725_init_schema',1);

@driesvints driesvints changed the title Using complete insert for mysqldump when appending migration dump to … [10.x] Using complete insert for mysqldump when appending migration dump to … Aug 21, 2023
@driesvints driesvints changed the title [10.x] Using complete insert for mysqldump when appending migration dump to … [10.x] Using complete insert for mysqldump when appending migration dump to schema file Aug 21, 2023
@taylorotwell taylorotwell merged commit 00b3cae into laravel:10.x Aug 21, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants