[10.x] Make the updateOrCreate methods in relations use firstOrCreate behind the scenes
#48213
+33
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpyw
changed the title
updateOrCreate methods in relations use firstOrCreateupdateOrCreate methods in relations use firstOrCreate
mpyw
changed the title
updateOrCreate methods in relations use firstOrCreateupdateOrCreate methods in relations use firstOrCreate behind the scenes
mpyw
force-pushed
the
use-first-or-create-in-relations
branch
from
4cc6211
to
892c9ba
Compare
mpyw
force-pushed
the
use-first-or-create-in-relations
branch
2 times, most recently
from
a6226a6
to
73265b4
Compare
mpyw
force-pushed
the
use-first-or-create-in-relations
branch
from
73265b4
to
5e1d32f
Compare
mpyw
commented
Aug 29, 2023
mpyw
force-pushed
the
use-first-or-create-in-relations
branch
from
a8394fc
to
0c6ebdb
Compare
tonysm
added a commit
to tonysm/framework
that referenced
this pull request
Sep 25, 2023
…rstOrCreate` behind the scenes (laravel#48213)" This reverts commit e1ae507.
taylorotwell
pushed a commit
that referenced
this pull request
Sep 25, 2023
…#48531) * Avoid using createOrFirst inside other *OrCreate methods * Revert "[10.x] Make the `updateOrCreate` methods in relations use `firstOrCreate` behind the scenes (#48213)" This reverts commit e1ae507. * Revert "Enhancing `updateOrCreate()` to Use `firstOrCreate()` (#48160)" This reverts commit 80e0262. * Fix mocked firstOrCreate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
updateOrCreate()to UsefirstOrCreate()#48160firstOrCreatemethods in relations usecreateOrFirstbehind the scenes #48192Add consistent fix for
updateOrCreatebased on #48160, since there was a consistent fix forfirstOrCreatein #48192.