[10.x] Fix firstOrNew on HasManyThrough relations
#48542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonysm
changed the title
firstOrNew on HasManyThrough relationsfirstOrNew on HasManyThrough relations
tonysm
force-pushed
the
fix-first-or-new-on-has-many-through
branch
from
8a2ca69
to
d8ad231
Compare
|
Tests are failing, but they seem unrelated to the changes here. We can wait for a fix to land in the |
|
@tonysm these are fixed on 10.x, can you rebase? |
tonysm
force-pushed
the
fix-first-or-new-on-has-many-through
branch
from
d8ad231
to
aec7422
Compare
|
@driesvints done! |
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Sep 27, 2023
* Fix the firstOrNew method on HasManyThrough relations * Add a test for the firstOrNew method when record exists * Invert the firstOrNew if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
firstOrNewmethod onHasManyThroughrelations. The other implementations of thefirstOrNewmethod all take the unique attributes plus an array of values to be merged on the new instance. This wasn't the case with theHasManyThroughrelation. I noticed this as I was trying to identify the root cause on a bug in theupdateOrCreatemethod. I've shared more context here.