-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Adds PHPUnit 11 support #49622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Jan 9, 2024
178ce22
to
a47307f
Compare
crynobone
approved these changes
Jan 9, 2024
crynobone
reviewed
Jan 10, 2024
Jubeki
reviewed
Jan 10, 2024
Co-authored-by: Julius Kiekbusch <contact@julius-kiekbusch.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for PHPUnit 11 and Pest 3 in Laravel 11. While at the same time, supporting PHPUnit 10 and Pest 2. @taylorotwell, please be aware that we have implemented a few changes at the
HandleExceptions
level that require your review:forgetApp
method in favor offlushState
.flushState
method not only forgets the app instance but also clears every exception|error handler previously set in PHP's global state. If PHPUnit had an error handler, we have reset it to the original one.Test code or tested code did not remove its own exception handlers
.@crynobone, could you please review and merge this pull request before we proceed with merging this one?