[10.x] fix: Restore the original error/exception handler on terminating app #49791
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natsuki Ikeguchi <me@s6n.jp>
siketyan
changed the title
|
Hi @siketyan, this issue is fixed on Laravel 11 (#49622) - just tested locally. However, feel that this is too big of a change to even port the fix that was made on Laravel 11. Lets see what @taylorotwell thinks. |
|
Note that this issue is causing unexpected test failure for |
|
@siketyan right now we don't support this on Laravel v10, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49237, #49593
HandleExceptions bootstrapper sets an error handler for the application, but does not restore the original handler after the run. This causes failure on isolated tests in PHPUnit on PHP 8.3. In addition, PHPUnit is going to detect the error handler which is not restored and mark as risky test since PHPUnit v11 (See sebastianbergmann/phpunit#5619).
Related pull request: sebastianbergmann/phpunit#5677