Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add query method to UrlGenerator contract docblock #51515

Merged
merged 2 commits into from
May 21, 2024

Conversation

hjanos-bc
Copy link
Contributor

#51075 added the very useful query helper to UrlGenerator

Since the UrlGenerator contract does not have this method, IDEs and static analyzer tools cannot understand or autocomplete it.

Adding it to the interface would be considered a breaking change, so I am using phpdoc here, and it can be added to the contract in Laravel 12 if preferred.

using phpdoc so it is not a breaking change
@crynobone crynobone changed the title Add query method to UrlGenerator contract [11.x] Add query method to UrlGenerator contract docblock May 21, 2024
@taylorotwell taylorotwell merged commit d912b91 into laravel:11.x May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants