New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix memory leak and potential caching issue with usePage #1366

Merged

taylorotwell merged 1 commit into 3.x from usepage-usage

Aug 23, 2023

Member

jessarcher commented Aug 23, 2023 •

edited

This PR fixes a memory leak and potential caching issue in the Vue stack when calling usePage inside a computed prop or watcher.

usePage should be called at the top level of <script setup> per the example in the docs at https://inertiajs.com/shared-data#accessing-shared-data.

See inertiajs/inertia#1602 (comment) for more information.


          Fix memory leak and potential caching issue with usePage

d3d9faf

taylorotwell merged commit 6660ede into 3.x

8 checks passed

taylorotwell deleted the usepage-usage branch

August 23, 2023 13:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment