Update remote.php #2608
Update remote.php #2608
Conversation
Array remote change
|
I'm not sure I understand this PR. Trailing commas is a common practice in PHP to allow quick additions to arrays in the future. |
|
Why all this pull requests spam? Surely this could have been all one pull marked as |
|
Also agreeing with @rtablada, I always leave trailing commas in my arrays, it's common practice. |
|
Agreed to both, if this was submitted at all, it should be in one PR marked as a change in style or changing white space. From a contributor, this mass of pull requests on multiple files making inconsequential changes appears as spam at best or a user trying to appear as a more significant contributor by stats. |
|
GitHub should have a ban button! |
|
YES)) |
|
basically are corrections I just took another frameword which is CakePHP'm just making the same change and improvements which in turn are validated with tests of frameword as such is not is contribullente but by making the change I see that I'm better at PHP style rules. if you want to take into account good but ok. in my version of laravel if this set. Greetings. |
|
oh and is not a span in several file are the same null array is not good implements an array (,,,,,,,) and please tell me they have. |
|
It's not an improvement! |
|
lol |
|
These changes do not help any way. The style guidelines for laravel may be different than cakePHP but they stay the same in terms of white space and array notation throughout the framework. This PR actually goes against the framework style and as mentioned hurts further extensibility in terms of adding items to the arrays as these configuration files are not limited to what is included by default. |
|
I lol'd |
|
Can someone close all of this spam please. |
|
|
|
|
|
He just spammed CakePHP with a few nonsense GitHub issues in return.. So where is the "ban" button again? |
Array remote change