New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Echo options for pusher in bootstrap.js #4525

Merged

taylorotwell merged 2 commits into laravel:master from pdziewa:bootstrap-pusher-fix

Dec 24, 2017

Contributor

pdziewa commented Dec 23, 2017

Details in laravel/docs PR 3932


          Update Echo options for pusher in bootstrap.js

a38c115

Contributor

antonkomarev commented Dec 24, 2017 •

edited

Loading

While we are changing this code, maybe it will be better to have trailing comma?

// window.Echo = new Echo({
//     broadcaster: 'pusher',
//     key: 'your-pusher-key',
//     cluster: 'eu',
//     encrypted: true,
// });

This helps git to have cleaner diffs and webpack working well with it.


          Update bootstrap.js

aad5940

taylorotwell merged commit b347461 into laravel:master

pdziewa deleted the bootstrap-pusher-fix branch

December 24, 2017 08:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment