Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Vite #5904

Merged
merged 6 commits into from
Jun 22, 2022
+22 −31
Merged

[9.x] Vite #5904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2c240d
Use Vite
jessarcher Jun 1, 2022
8b3950c
Gitignore Vite build directory
jessarcher Jun 1, 2022
6b43cfa
Use CSS entry points
jessarcher Jun 13, 2022
f794227
Update plugin
jessarcher Jun 14, 2022
c6eabb6
Linting
jessarcher Jun 15, 2022
5aa18b6
Update plugin
jessarcher Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ PUSHER_APP_KEY=
PUSHER_APP_SECRET=
PUSHER_APP_CLUSTER=mt1

MIX_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
MIX_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
VITE_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
VITE_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/node_modules
/public/build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this added?? I tried to use npm run build locally so that my assets are production ready because I need to deploy to production, I was expecting that it should work on prod without the need to install npm packages...

does this mean that i should do an npm install then npm run build in prod?

I'm getting error

Vite manifest not found at: /releases/1670917824/public/build/manifest.json

Am I missing something here? maybe a link to a docs that helps me with deploying vite assets to prod?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind I found this https://github.com/laravel/vite-plugin/blob/main/UPGRADE.md#optional-git-ignore-the-build-directory

This is preference base and Laravel is just more inclined in building assets during deployment.

The /public/build can just be commented out.

/public/hot
/public/storage
/storage/*.key
Expand Down
2 changes: 1 addition & 1 deletion .styleci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ php:
js:
finder:
not-name:
- webpack.mix.js
- vite.config.js
css: true
14 changes: 5 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
{
"private": true,
"scripts": {
"dev": "npm run development",
"development": "mix",
"watch": "mix watch",
"watch-poll": "mix watch -- --watch-options-poll=1000",
"hot": "mix watch --hot",
"prod": "npm run production",
"production": "mix --production"
"dev": "vite",
"build": "vite build"
},
"devDependencies": {
"axios": "^0.25",
"laravel-mix": "^6.0.6",
"laravel-vite-plugin": "^0.2.1",
"lodash": "^4.17.19",
"postcss": "^8.1.14"
"postcss": "^8.1.14",
"vite": "^2.9.11"
}
}
4 changes: 2 additions & 2 deletions resources/js/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';

// window.Echo = new Echo({
// broadcaster: 'pusher',
// key: process.env.MIX_PUSHER_APP_KEY,
// cluster: process.env.MIX_PUSHER_APP_CLUSTER,
// key: import.meta.env.VITE_PUSHER_APP_KEY,
// cluster: import.meta.env.VITE_PUSHER_APP_CLUSTER,
// forceTLS: true
// });
11 changes: 11 additions & 0 deletions vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { defineConfig } from 'vite';
import laravel from 'laravel-vite-plugin';

export default defineConfig({
plugins: [
laravel([
'resources/css/app.css',
'resources/js/app.js',
]),
],
});
17 changes: 0 additions & 17 deletions webpack.mix.js
View file
Open in desktop

This file was deleted.