Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit, delete & action buttons missing from details page when using all Panels as fields #219

Closed
David-Griffiths opened this issue Aug 26, 2018 · 13 comments
Labels
bug Verified bug by the Nova team

Comments

@David-Griffiths
Copy link

This shows the correct details page header buttons:

return [
	ID::make()->sortable(),
	new Panel('Data', $this->dataFields()),
];

buttons


This does not:

return [
	new Panel('Data', $this->dataFields()),
];

nobuttons

@m-a-k-o
Copy link

m-a-k-o commented Aug 26, 2018

I don't see button in details also when I have ID defined inside fields.

@David-Griffiths
Copy link
Author

Done some more testing, and the issue only happens when the first item in the fields array is a Panel.

@m-a-k-o
Copy link

m-a-k-o commented Aug 26, 2018

Not my case. I don't have panel inside fields and I also included ID but no buttons.

image

image

@lucasromanojf
Copy link

Yeah I never saw these buttons and actions too

@beliolfa
Copy link

I just realized that those buttons even exist! Never saw them

@lucasromanojf
Copy link

lucasromanojf commented Aug 27, 2018

This is what is causing this bug (Detail.vue file):

image

That will never work for localized apps or if you don't have the default "Details" panel.

@beliolfa
Copy link

wow the whole v-if is relying in a text fragment! Nice catch @lucasromanojf

@ghost
Copy link

ghost commented Sep 6, 2018

@lucasromanojf nice catch!

@davidhemphill
Copy link
Contributor

This has been fixed in laravel/nova#79 and will be included in an upcoming release.

@vernard
Copy link

vernard commented Jan 12, 2019

I'm using v1.3.0 and this is still not fixed.

This doesn't show the action button:
image
image

But this one does:
image
image

Having hideFromDetail() on the ID field makes the edit and delete button disappear.

@dkulyk
Copy link

dkulyk commented Jan 12, 2019

(new Panel(...))->withToolbar()

@vernard
Copy link

vernard commented Jan 12, 2019

Worked for me. Thanks @dkulyk

harmenjanssen added a commit to grrr-amsterdam/nova-pages-tool that referenced this issue Jan 26, 2021
See also this discussion for why this is necessary: laravel/nova-issues#219
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team
Projects
None yet
Development

No branches or pull requests

7 participants