Translations not working properly

[lucasromanojf]

The translations (using the json file) are only working on the login screen. They are not working inside resource's index for example.

Also, some texts are not possible to translate. Some examples are the "Search" text (inside search fields), the "TRASHED:" text (inside index filters) and "No {resource} matched the given criteria." (grids) that are hardcoded.

[gdespirito]

+1

[gdespirito]

I fixed it changing the route where the app is looking for the translations on Nova. I think it would be an easy fix.

[themsaid]

make sure you're running latest Nova.

[lucasromanojf]

I'm running 1.0.5. Translations json is working now, but there are still hardcoded texts.

[BlazL]

+1
I'm running 1.0.8.

[ghost]

+1
I'm running 1.0.12

[themsaid]

Can anyone share what the issue is? Translations are working fine for me and I can't replicate the issue, if someone can share more information that'd be great.

[ghost]

Hello @themsaid,

open resources/views/Index.vue line 226:

                    `No {{resourceInformation.label.toLowerCase()}} matched the given criteria.`

The string is hardcoded and I can't translated it by editing en.json or <language_code>.json

Same thing for GlobalSearch and Search components: placeholders strings are hardcoded.

Try to create a new language file and edit "Search" and "No :resource matched the given criteria." tokens. Refresh the page and you will see strings remain untranslated.

[bonzai]

Translations are (almost) working, except there are a lot of hardcoded strings inside Vue components:

• Hardcoded texts #32
• Textarea Show Content / Hide Content hardcoded #160
• …

Also some functions stops working if the current language is not English:

• Edit, delete & action buttons missing from details page when using all Panels as fields #219 (comment)

[themsaid]

#219 wow, thanks for pointing this out.

[themsaid]

Thanks @antoniolore and @bonzai. I'm working on it.

[gvsrepins]

Hello @themsaid! Thank you for the support.

To help on this matter.. I was only able to translate a BelongsTo field, making an overwrite of the indexName value. I think that this was not the intented Behavior since it's not documented.

Se code bellow to clarify:

BelongsTo::make('Activity')
                    ->singularLabel(__('Activity'))
                    ->nullable()
                    ->searchable()
                    ->withMeta(['indexName' => __('Activity')]),

PS: Only tested with BelongsTo, but it probably should happens with others realtionship fields to.