Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth Client ID with string #49

Closed
wants to merge 2 commits into from
Closed

OAuth Client ID with string #49

wants to merge 2 commits into from

Conversation

nueko
Copy link

@nueko nueko commented Aug 23, 2016

Fix #14

@nueko nueko mentioned this pull request Aug 23, 2016
Closed
@GrahamCampbell
Copy link
Member

It's too late to change this now that 1.0.0 is out.

@nueko
Copy link
Author

nueko commented Aug 23, 2016

although i don't understand the 'too late' words mean. That's okay, I made it for my sake 😄

@GrahamCampbell
Copy link
Member

Well, it could be considered for 2.x I guess.

@lucasmichot
Copy link
Contributor

Hey @nueko , thanks for bootstrapping this !
For the client ID, I think I would stick to a random string I guess, unless @taylorotwell got another approach

As long as it's unique AND indexed

@nueko
Copy link
Author

nueko commented Aug 23, 2016

You are welcome.
i think, if random string will never generate duplicate, it will be ok.

@tobiasthaden tobiasthaden mentioned this pull request Dec 13, 2017
Closed
utsavsomaiya added a commit to utsavsomaiya/passport that referenced this pull request Aug 31, 2023
@utsavsomaiya
Merge pull request laravel#49 from Artisans-PXM/pr_changes
66b3f2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nueko @GrahamCampbell @lucasmichot @taylorotwell