Bump to Laravel v10 & PHP 8.2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessarcher this is ready but it seems existing tests seem to fail. I wonder if the failure has anything to do with laravel/framework#45500 ? |
|
@driesvints I fixed the issue by making Testbench load the Livewire service provider so that Livewire is registered. I'm not sure if this is the correct way to solve the issue, but it works 🤷♀️ I've also confirmed that this issue existed prior to this PR. |
jessarcher
approved these changes
Jan 18, 2023
|
@jessarcher lgtm! |
woodspire
referenced
this pull request
in woodspire/pulse
Dec 1, 2023
Fix problem doing "composer require laravel/pulse"
Uncaught TypeError: Laravel\Pulse\Pulse::Laravel\Pulse\{closure}(): Argument #1 ($event) must be of type Illumi
nate\Events\Dispatcher, Illuminate\Events\NullDispatcher given, called in /var/www/sapere/sapere/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 1302 and defined in /var/www/sapere/sapere/vendor/laravel/pulse/src/Pulse.php:119
Stack trace:
taylorotwell
pushed a commit
that referenced
this pull request
Dec 1, 2023
Fix problem doing "composer require laravel/pulse"
Uncaught TypeError: Laravel\Pulse\Pulse::Laravel\Pulse\{closure}(): Argument #1 ($event) must be of type Illumi
nate\Events\Dispatcher, Illuminate\Events\NullDispatcher given, called in /var/www/sapere/sapere/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 1302 and defined in /var/www/sapere/sapere/vendor/laravel/pulse/src/Pulse.php:119
Stack trace:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps dependencies to PHP 8.2 & Laravel v10. It also adds the default GitHub files and a CI build.
Depends on: