Laravel v10 Support #5507
Merged
Laravel v10 Support #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2023
|
@driesvints thanks! I'll get Caleb to have a look at the Sushi PR. We also have an open PR to fix another issue with Laravel 10, see #5505. |
|
Cool, we already got most of the Sushi PR done, just one failure left. |
7 tasks
1 task
…s or greater as this issue has been fixed/update again in the next version of Laravel 9, see laravel/framework#45602
|
Laravel 10 tests we're failing due to newer updates/fixes to the recent rounding changes in Laravel merged into L10. So I've updated version comparisons in our tests to not include any newer Laravel 9 versions or greater. I've also merged @27pchrisl's changes from PR #5505 into this PR so it's all together. Thanks everyone for your help on this PR! 🙂 |
|
Thanks @joshhanley! |
calebporzio
pushed a commit
that referenced
this pull request
Jul 20, 2023
Laravel 10 support had already been added to composer.json, so just needed to add storage signature fix and enable in GitHub actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Laravel v10 support. We'll need this to update Jetstream: laravel/jetstream#1216
Depends on: