Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Ensure missing user does not throw a type error #366

Merged
merged 1 commit into from
May 8, 2024

Conversation

timacdonald
Copy link
Member

Fixes #364, #324

Due to what is described in laravel/fortify#536, Pulse will throw a type error if a null user is attached to the Logout event.

Although we are fixing this across the ecosystem, we should fix this for users that have not updated the packages or are using laravel/ui, which does not get a backwards fix, i.e., only new laravel/ui usages get the fix.

@taylorotwell taylorotwell merged commit b6f3ed6 into laravel:1.x May 8, 2024
18 checks passed
@timacdonald timacdonald deleted the logout branch May 8, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in Pulse::rememberUser() (Logout Event)
2 participants